Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat|Bug] How to with DLL's? #125

Open
luchillo17 opened this issue Oct 25, 2016 · 8 comments
Open

[Feat|Bug] How to with DLL's? #125

luchillo17 opened this issue Oct 25, 2016 · 8 comments

Comments

@luchillo17
Copy link

No description provided.

@NekR
Copy link
Owner

NekR commented Oct 25, 2016

What's wrong exactly with DLLs?

On Oct 26, 2016 2:03 AM, "Carlos Esteban Lopez Jaramillo" <
notifications@github.com> wrote:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#125, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABIlkVxpTOhto5uFloCCU_Cy6QZ_scTFks5q3orEgaJpZM4KglRt
.

@luchillo17
Copy link
Author

The dlls are not included in the files that should be cached by the plugin, most likely is because the way it is configured, care to take a look at the config? here i see where the config references the dlls and uses the copy plugin to paste in the output folder: https://github.com/Luchillo/angular2-webpack-starter/blob/master/webpack.config.ts#L207-L226

@NekR
Copy link
Owner

NekR commented Oct 26, 2016

Hmm.. it supposed to work with everything what is generated, e.g. it works fine with html-webpack-plugin for sure. Though, dll-plugin may do some different kind of generation, I'll check that. But in general, I don't think that it's a good idea to use offline-plugin in dev builds. It's mostly a production feature, while DLLs are development feature.

@luchillo17
Copy link
Author

Oh is that so? why not using dll's in production? what's the difference with a pollyfil file with the same libs imported on it?

@NekR
Copy link
Owner

NekR commented Nov 1, 2016

@Luchillo I'm not sure if there is a problem, I just never saw it being using in production. I'll do some research on that and if makes sense to use DLL plugin in production I'll try to fix the issue.

@luchillo17
Copy link
Author

I've looking a bit more in the build process, and indeed it generates dlls only for dev, in prod it generates normal libs, so the issue may not be valid, i'm still curious about why dlls can't become libs like vendor or pollyfil files, or rather what's the difference in generated code with dlls and normal files..

@NekR
Copy link
Owner

NekR commented Nov 10, 2016

@Luchillo I'll look into a problem with DLLs, not sure when though. But it's weird that this problem is even exists.

@luchillo17
Copy link
Author

Have a look, this is the dev network traffic and build cache using the dll's:
image

image

Meanwhile this is the prod build cache which indeed works as expected:
image

As you should be able to tell, the production build does have the pollyfil and vendor files which are the ones turned into DLL's in the development build, so it seems to work as expected, now i only have to ask the angular.

But one thing i've noticed is that if i stop the server the app doesn't work unless is a brand new tab, and after first reload it breaks, i keep getting this:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants