Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update exceptions.py #43

Closed
wants to merge 1 commit into from
Closed

Conversation

ldbfpiaoran
Copy link

Will be generated when using dirhunt for ip with https certificate
ssl.CertificateError: hostname XXXX doesn't match either of
Anomaly. For example dirhunt https://42.186.69.33/venus/projects/_/users

Will be generated when using dirhunt for ip with https certificate
ssl.CertificateError: hostname XXXX doesn't match either of
Anomaly. For example dirhunt https://42.186.69.33/venus/projects/_/users
@codecov
Copy link

codecov bot commented Jul 30, 2018

Codecov Report

Merging #43 into develop will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #43      +/-   ##
===========================================
+ Coverage    91.08%   91.17%   +0.08%     
===========================================
  Files           28       28              
  Lines         1324     1326       +2     
===========================================
+ Hits          1206     1209       +3     
+ Misses         118      117       -1
Impacted Files Coverage Δ
dirhunt/exceptions.py 100% <100%> (ø) ⬆️
dirhunt/pool.py 85.71% <0%> (+4.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca103e0...3eec5a9. Read the comment docs.

@Nekmo
Copy link
Owner

Nekmo commented Jul 30, 2018

Exists any solution without patching core SSL library? Dirhunt can be used as a module in other projects, causing this change a problem.

I'm going to investigate this, If you find something, let me know.

Thank you.

@ldbfpiaoran
Copy link
Author

@Nekmo Yes, it can ignore the certificate just like the parameters of the requests library, but there should be an official urllib library in dirhunt that works with python, so this happens.

@Nekmo
Copy link
Owner

Nekmo commented Jul 30, 2018

Fixed on Issue #44 and Issue #45 without patch core libraries. Please check the development branch.

@Nekmo
Copy link
Owner

Nekmo commented Aug 11, 2018

This is solved on issues #44 and Issue #45.

Thank you.

@Nekmo Nekmo closed this Aug 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants