Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

path generation code ignores the ROOT_URL env var #68

Open
csillag opened this issue May 17, 2016 · 4 comments
Open

path generation code ignores the ROOT_URL env var #68

csillag opened this issue May 17, 2016 · 4 comments

Comments

@csillag
Copy link
Contributor

csillag commented May 17, 2016

When running our Meteor 1.3 project, we have the ROOT_URL env var set to /whatever/,
and so all the resources are served under that path.

However, in the autogererated custom.bootstrap.less, I see this line:

@icon-font-path: "/packages/nemo64_bootstrap-data/bootstrap/fonts/";

This path doesn't contain the ROOT_URL, and consequently, fonts don't work.

In the meteor code, the path should be generated by the Meteor.absoluteUrl() function, which automatically honors the env var.

@simison
Copy link
Contributor

simison commented May 17, 2016

See Readme — this package works only with 1.1 and older.

csillag added a commit to go-e/meteor-bootstrap that referenced this issue May 17, 2016
...when generating the font path.

See Nemo64#68
simison added a commit to simison/meteor-bootstrap that referenced this issue May 17, 2016
csillag added a commit to go-e/meteor-bootstrap that referenced this issue May 17, 2016
...when generating the font path.

See Nemo64#68
@csillag
Copy link
Contributor Author

csillag commented May 17, 2016

Well, for me, it works OK with Meteor 1.3... and this PR fixes the problem:

#70

@simison
Copy link
Contributor

simison commented May 17, 2016

Oh, that's interesting! Perhaps it simply started working again. With 1.2 it didn't work. :-)

@Nemo64 @emgee3 do you know about this?

Nevertheless https://github.com/huttonr/bootstrap3 is better up to date.

@emgee3
Copy link
Collaborator

emgee3 commented May 17, 2016

Honestly haven't looked because I've been using huttonr's package...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants