Skip to content

Conversation

janikapeters
Copy link

Functions with both names existed with some taking the same arguments and computing the same thing.

@lgoettgens
Copy link
Member

@fingolfin @fieker any objections?

Copy link

codecov bot commented Sep 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.93%. Comparing base (4b127f8) to head (01d2cae).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2168   +/-   ##
=======================================
  Coverage   87.93%   87.93%           
=======================================
  Files         127      127           
  Lines       31776    31776           
=======================================
  Hits        27941    27941           
  Misses       3835     3835           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lgoettgens
Copy link
Member

This is unfortunately incompatible with the current Oscar master as this PR here turns https://github.com/oscar-system/Oscar.jl/blob/73e4186aa042c4f719dc06752f82bdd2da1bc572/src/Modules/UngradedModules/SubquoModule.jl#L2175 into a self-call (resulting in a StackOverflow when called).

Since I still want to get this in eventually, I mark this as technically breaking, so we remember to add it to the next breaking AA release.

@fingolfin
Copy link
Member

I am fine with this but as you say, there is a problem with doing that in OSCAR. So first we need to change OSCAR to delegate the other way there (resp. turn rels there into an alias for relations).

So someone should open an issue for OSCAR, or provide a PR, to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants