Skip to content

Conversation

fingolfin
Copy link
Member

@fingolfin fingolfin commented Oct 1, 2025

No description provided.

@fingolfin fingolfin added enhancement New feature or request performance must go faster release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes labels Oct 1, 2025
Copy link

codecov bot commented Oct 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.92%. Comparing base (f69ac97) to head (bf0405d).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2178   +/-   ##
=======================================
  Coverage   87.92%   87.92%           
=======================================
  Files         127      127           
  Lines       31780    31783    +3     
=======================================
+ Hits        27943    27946    +3     
  Misses       3837     3837           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@joschmitt joschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't say that I ever used the universal polynomial ring, but this looks fine to me.

I am a bit wary that the copy of an MPoly might now share coefficients with the original polynomial as opposed to what it did before. But the tests pass, so we are good?!

@fingolfin
Copy link
Member Author

You make a fair point, @joschmitt . I'll split this PR into two: one which adds the copy method for UnivPoly, and one with the "optimization" where we need to decide if that's what we want or not (perhaps not)

@fingolfin fingolfin changed the title Optimize copy(::Generic.MPoly) and add copy(::UnivPoly) Add copy(::UnivPoly) Oct 2, 2025
@fingolfin fingolfin enabled auto-merge (squash) October 2, 2025 15:43
@fingolfin fingolfin merged commit 6a52300 into master Oct 2, 2025
21 checks passed
@fingolfin fingolfin deleted the mh/copy-poly branch October 2, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request performance must go faster release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants