Stop using fmpz_mod_mat_rank again

Nemocas · Dec 9, 2024 · 69b5396 · 69b5396
1 parent 2f0fc3d
commit 69b5396
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/src/flint/fmpz_mod_mat.jl b/src/flint/fmpz_mod_mat.jl
@@ -389,11 +389,18 @@ end
 #
 ################################################################################
 
+#= There are some doubts whether fmpz_mod_mat_rank is what we want: there are
+several non-equivalent ways to define the rank of a matrix over a ring with
+zero divisors. FLINT does not seem to document what exactly fmpz_mod_mat_rank
+computes...
+
 function rank(a::T) where T <: Zmod_fmpz_mat
   r = @ccall libflint.fmpz_mod_mat_rank(a::Ref{T}, base_ring(a).ninv::Ref{fmpz_mod_ctx_struct})::Int
   return r
 end
 
+=#
+
 ################################################################################
 #
 #  Inverse