Remove dependency on Pkg #1964
Merged
Remove dependency on Pkg #1964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am happy to disable it on 1.6. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1964 +/- ##
==========================================
+ Coverage 87.93% 87.97% +0.04%
==========================================
Files 99 99
Lines 36467 36458 -9
==========================================
+ Hits 32067 32074 +7
+ Misses 4400 4384 -16 ☔ View full report in Codecov by Sentry. |
- `versioninfo` was just broken, so remove it - parse `Project.toml` to get package version - replace heuristic for detecting dev versions by a new one which checks for the presence of a `.git` dir -- this catches a few more cases than what we have right now - move banner printing code into a new helper `show_banner` which makes it easier to test changes to it
|
Fixed 1.6 support |
lgoettgens
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
versioninfowas just broken, so remove itProject.tomlto get package version.gitdir -- this catches a few more cases than what we have right nowshow_bannerwhich makes it easier to test changes to itResolves #1895
Closes #1896