Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump AbstractAlgebra to 0.44.0 #1972

Merged
merged 3 commits into from
Dec 13, 2024
Merged

Bump AbstractAlgebra to 0.44.0 #1972

merged 3 commits into from
Dec 13, 2024

Conversation

lgoettgens
Copy link
Collaborator

@lgoettgens lgoettgens commented Dec 13, 2024

Replaces and thus closes #1970.

Includes the following PRs that try to fix compatibility with AA 0.44.0.

lgoettgens and others added 3 commits December 13, 2024 10:02
Co-authored-by: Max Horn <max@quendi.de>
Co-authored-by: Tommy Hofmann <thofma@gmail.com>
* Remove duplicate polynomial call functions

* Remove `polysubst.jl` as this is now covered by AA
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.98%. Comparing base (defef89) to head (dff945e).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/flint/fmpz_mat.jl 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1972      +/-   ##
==========================================
+ Coverage   87.96%   87.98%   +0.02%     
==========================================
  Files          99       98       -1     
  Lines       36485    36450      -35     
==========================================
- Hits        32095    32072      -23     
+ Misses       4390     4378      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lgoettgens lgoettgens merged commit 24ac955 into master Dec 13, 2024
23 of 24 checks passed
@lgoettgens lgoettgens deleted the lg/bump-AA-0.44 branch December 13, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants