sanitize the solve_triu and sync with AA #1958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
technically breaking as _solve_triu is now AA._solve_triu
fingolfin
reviewed
Dec 3, 2024
fingolfin
reviewed
Dec 3, 2024
src/flint/fmpz_mat.jl
Outdated
Comment on lines
1558
to
1560
| if side == :right | ||
| return AbstractAlgebra._solve_triu(U, b; side) | ||
| end |
There was a problem hiding this comment.
uh... why does _solve_triu_left have a side parameter to begin with?!?
As far as I can tell nothing calls _solve_triu_left except one test case in Nemo.jl. So we could also just remove it?
There was a problem hiding this comment.
No. solve_triu left is essential for the stuff in Hecke. The solve right is not used (currently)
There was a problem hiding this comment.
I agree with @fingolfin that _solve_triu should have the side kwarg and dispatch to different methods depending on it. _solve_triu_left should not have to deal with these things.
fingolfin
reviewed
Dec 3, 2024
|
I will clean it up |
lgoettgens
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
technically breaking as _solve_triu is now AA._solve_triu