Warning in fmpz_mat tests

[wbhart]

fmpz_mat.convert...WARNING: When trying to convert a fmpz_mat to a Matrix{Int}, some elements were too large to fit the standard Int type: try to convert to a matrix of BigInt.

[thofma]

That is on purpose to test the warning.

[wbhart]

I bet it gets reported a lot.

…

On 22 August 2017 at 12:44, thofma ***@***.***> wrote: That is on purpose to test the warning. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#236 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAOzpnB0mQB_zwLaO3O_7DB5zTUMlx8fks5sarD2gaJpZM4O-Znx> .

[kalmarek]

how about using @test_warn?
JuliaLang/julia#19903

[wbhart]

This is only in Julia-0.7, yes?

[kalmarek]

I have it in my julia-0.6

[wbhart]

Ok, then I guess we should do that then.

[wbhart]

The problem is that the test actually throws an InexactError. We currently use @test_throws for this, but it transmutes the error into a warning, which is then printed. I don't see how to work around this. It seems like a bug in Julia to me.

…

On 22 August 2017 at 13:37, kalmarek ***@***.***> wrote: I have it in my julia-0.6 — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#236 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAOzpnp1KutLZ7jHHZYIh_5WENF2ZL39ks5sar1tgaJpZM4O-Znx> .

[thofma]

The function first gives a warning and then throws an error. We cannot test both in the test. How about we only throw the error, but change it's text to the text of the warning?

[wbhart]

Sounds fair.

…

On 13 October 2017 at 14:53, thofma ***@***.***> wrote: The function first gives a warning and then throws an error. We cannot test both in the test. How about we only throw the error, but change it's text to the text of the warning? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#236 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAOzpjy2M4YckpOmXqxhdBIFNNSiY3Dwks5sr10ygaJpZM4O-Znx> .