Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the hack to make threaded flint work #622

Open
thofma opened this issue Sep 17, 2019 · 5 comments
Open

Remove the hack to make threaded flint work #622

thofma opened this issue Sep 17, 2019 · 5 comments

Comments

@thofma
Copy link
Member

thofma commented Sep 17, 2019

Do this once JuliaLang/julia#33284 is merged.
@wbhart
Copy link
Contributor

wbhart commented Jul 28, 2021

It has been merged.

@thofma
Copy link
Member Author

thofma commented Jul 29, 2021

Did not make it into any 1.0 release, see JuliaLang/julia#34011.

@fingolfin
Copy link
Member

@thofma what is the hack that is being talked about here? is it this bit of code in __init__ perhaps?

  if __isthreaded[]
    @ccall :libgmp.__gmp_set_memory_functions(0::Int, 0::Int, 0::Int)::Nothing
  end

I am basing this on the commit message and date of 96663d9 but I am just guessing...

@thofma
Copy link
Member Author

thofma commented Dec 5, 2024 •
edited
Loading

yes, I think it is the same thing we discussed in oscar-system/LoadFlint.jl#7

@fingolfin
Copy link
Member

So then we can remove this now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fingolfin @wbhart @thofma