Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Backports release 1.0.6 #34011

Closed
wants to merge 15 commits into from
Closed

Conversation

KristofferC
Copy link
Member

@KristofferC KristofferC commented Dec 3, 2019

Backported PRs:

Need manual backport:

Contains multiple commits, manual intervention needed:

Non-merged PRs with backport label:

We avoid computing axes for tuples -- which is a valuable optimization -- but when we explicitly construct a tuple broadcast with axes pre-set (for, e.g., broadcasted assignment), we need to check that those axes are compatible with the ones inside the broadcasted expression before accepting them.

(cherry picked from commit b5c4e63)
@KristofferC KristofferC added DO NOT MERGE Do not merge this PR! needs nanosoldier run This PR should have benchmarks run on it needs pkgeval Tests for all registered packages should be run with this change labels Dec 3, 2019
@JeffBezanson
Copy link
Member

Added #31670 to fix #34513.

@JeffBezanson JeffBezanson added the triage This should be discussed on a triage call label Feb 20, 2020
@KristofferC
Copy link
Member Author

Ran the script again to backport some stuff and update the list.

@KristofferC KristofferC force-pushed the backports-release-1.0 branch 2 times, most recently from 229f296 to eb1770a Compare February 20, 2020 21:28
tgflynn and others added 2 commits February 20, 2020 22:29
* Fix behavior of Sys.which when passed an empty String argument

* Added test to check for fixed Sys.which behavior with empty string input

* Added test to check that Sys.which returns nothing when passed a blank
string

* Ensure that Sys.which returns a regular file and never a directory

* Moved new Sys.which tests into test/spawn.jl alongside the existing ones

* Remove new which tests from test/sysinfo.jl (they've moved to
test/spawn.jl)

(cherry picked from commit fa235cc)
…33228)

This has the following advantages:

* It allows our buildbots to pass in which code signing identity they
want to use (rather than having the identity hash hardcoded in our build
system)

* It stops blindly attempting to codesign on random user's machines

* It causes codesign failure to stop the build

(cherry picked from commit 0760842)
@KristofferC KristofferC force-pushed the backports-release-1.0 branch from eb1770a to 47851db Compare February 20, 2020 21:30
stevengj and others added 10 commits February 22, 2020 21:42
* bug fixes in matrix log

* patches to matrix log (#33245)

* patches to matrix log

Avoid integer overflow if `s > 63`.
Correct logic for `s == 0`.
Only use fancy divided difference formulae if eigenvalues are close - avoids dangerous roundoff error if they are in opposite sectors.

* add tests

(cherry picked from commit 318affa)
This was a hold-over from the old iteration protocol, which needed to maintain state between `done` and `next`.
The `iteration` function of `Dict` has since been re-written to be safe for concurrent deletions.

Replaces: #33756
Co-Authored-By: Hans-Peter Suter <hps@treetron.ch>
(cherry picked from commit 1731d0a)
* Fix colon-reshaping of OffsetVector
* reshape(::AbstractVector, ::Colon) is a no-op

(cherry picked from commit f80c3ee)
* Remove SuiteSparse driver mention in the license, since it is the same as the rest of Julia.

Co-authored-by: Viral B. Shah <viral@juliacomputing.com>
(cherry picked from commit 1878343)
@KristofferC KristofferC force-pushed the backports-release-1.0 branch from 47851db to 3457d4c Compare February 22, 2020 20:43
@KristofferC
Copy link
Member Author

CMake Error: Could not find CMAKE_ROOT !!!
CMake has most likely not been installed correctly.
Modules directory not found in
/share/cmake-3.14.5
CMake Error: Error executing cmake::LoadCache(). Aborting.

for Windows.

@JeffBezanson JeffBezanson removed the triage This should be discussed on a triage call label Feb 27, 2020
Keno and others added 2 commits April 15, 2020 18:00
Upstream has apparently modified this file as of March 30th 2020, which
is annoying as it has broken all older builds of Julia attempting to
download and check this file.

(cherry picked from commit c980519)
@Keno
Copy link
Member

Keno commented Dec 29, 2020

I'm assuming 1.0.6 isn't happening at this point. If anybody was planning to take that on, feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs nanosoldier run This PR should have benchmarks run on it needs pkgeval Tests for all registered packages should be run with this change
Projects
None yet
Development

Successfully merging this pull request may close these issues.