Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version UnicodeData.txt filename #35383

Merged
merged 1 commit into from
Apr 6, 2020
Merged

Conversation

staticfloat
Copy link
Member

We've been downloading multiple different versions of UnicodeData.txt across different branches and trying to keep a consistent checksum.

We've been downloading multiple different versions of `UnicodeData.txt`
across different branches and trying to keep a consistent checksum.
@StefanKarpinski
Copy link
Member

Now I feel bad for blaming them for changing the data without versioning 😬

@staticfloat
Copy link
Member Author

Yeah, I think what happened is that b6c06dd ran with an old version of UnicodeData.txt cached, then once we tried to actually download it, it failed and when I looked at the "updated" date for 13.0 on the caching server, I saw it had been modified recently, so I assumed that upstream had changed, which really we had just added the 13.0 URL recently.

To the sysadmins of the Unicode Consortium that I'm sure are watching this repository with bated breath, I sincerely apologize for flinging blame at you. My bad.

@staticfloat staticfloat merged commit 922891c into master Apr 6, 2020
@staticfloat staticfloat deleted the sf/version_unicode_data branch April 6, 2020 22:09
KristofferC pushed a commit that referenced this pull request Apr 7, 2020
We've been downloading multiple different versions of `UnicodeData.txt`
across different branches and trying to keep a consistent checksum.

(cherry picked from commit 922891c)
@KristofferC KristofferC mentioned this pull request Apr 15, 2020
56 tasks
ztultrebor pushed a commit to ztultrebor/julia that referenced this pull request Apr 17, 2020
We've been downloading multiple different versions of `UnicodeData.txt`
across different branches and trying to keep a consistent checksum.
staticfloat added a commit that referenced this pull request Apr 21, 2020
We've been downloading multiple different versions of `UnicodeData.txt`
across different branches and trying to keep a consistent checksum.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants