Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes for the runtime (interpreted intrinsics) #29721

Merged
merged 4 commits into from
Nov 5, 2018
Merged

fixes for the runtime (interpreted intrinsics) #29721

merged 4 commits into from
Nov 5, 2018

Conversation

vtjnash
Copy link
Sponsor Member

@vtjnash vtjnash commented Oct 19, 2018

closes #29379

@vtjnash vtjnash added kind:bugfix This change fixes an existing bug backport pending 1.0 labels Oct 19, 2018
ararslan
ararslan reviewed Oct 19, 2018
View reviewed changes
src/builtins.c Outdated Show resolved Hide resolved
@KristofferC KristofferC mentioned this pull request Oct 19, 2018
Merged
@vtjnash
compiler: handle old-form IR in compute_basic_blocks
9707410
@vtjnash
runtime: fix definition of checked-intrinsics
500d669 
Handle case where runtime_nbits is not a power of two,
and be more careful to avoid C compiler undefined behavior
and tricky promotion rules when defining these.
@vtjnash
interpreter: in phi node, val may be explicitly null
abc6654 
previously, we only handled the case where it was implicitly null
@vtjnash
runtime: make setfield! error text consistent
386a8c2
@vtjnash vtjnash merged commit 1f2b16f into master Nov 5, 2018
@vtjnash vtjnash deleted the jn/interpret-intrinsics branch November 5, 2018 16:34
@StefanKarpinski
Copy link
Sponsor Member

Does that mean that all tests pass in the interpreter now?

@KristofferC KristofferC mentioned this pull request Nov 12, 2018
Merged
61 tasks
@KristofferC
Copy link
Sponsor Member

KristofferC commented Nov 19, 2018 •
edited
Loading

Does not backport cleanly. Please push backport to "backport-1.0.3" or make a rebased branch on top of that and I will backport the commits. @vtjnash

@StefanKarpinski StefanKarpinski added status:triage This should be discussed on a triage call backport 1.0 and removed status:triage This should be discussed on a triage call labels Jan 31, 2019
@KristofferC
Copy link
Sponsor Member

Doesn't seem the backport will happen.

@KristofferC KristofferC removed backport 1.0 status:triage This should be discussed on a triage call labels Jan 31, 2019
@sostock sostock mentioned this pull request Aug 26, 2019
Closed
@KristofferC KristofferC mentioned this pull request Dec 3, 2019
Closed
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanKarpinski StefanKarpinski StefanKarpinski left review comments

@ararslan ararslan ararslan left review comments

Assignees
No one assigned
Labels
kind:bugfix This change fixes an existing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tests known to fail in the interpreter
4 participants
@vtjnash @StefanKarpinski @KristofferC @ararslan