Make SuiteSparse wrapper thread safe. #34546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasnoack
added
backport 1.0
bugfix
Fixes #34500
andreasnoack
force-pushed
the
an/suitesparsethreads
branch
from
68803a3 to
65ca43c
Compare
KristofferC
pushed a commit
that referenced
this pull request
Jan 31, 2020
Fixes #34500 (cherry picked from commit 51f1710)
26 tasks
56 tasks
mtanneau
added a commit
to ds4dm/Tulip.jl
that referenced
this pull request
Feb 29, 2020
Julia version is restricted to 1.3 until modifications in CHOLMOD brought by JuliaLang/julia#34546 are addressed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By storing an instance of the
cholmod_commonstruct per thread. We might be able to utilize a similar approach to supportInt32indices.Fixes JuliaLang/LinearAlgebra.jl#691