codegen: fix bug with String egal test #31585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were using && test where we meant to use ||. fix #31583
Avoid emitting a branch-and-error check for impossibly large strings
JeffBezanson
approved these changes
Apr 2, 2019
|
I can confirm that on 1.3 DEV this is fixed. Thank you! EDIT: I mean it resolves #32842 issue |
55 tasks
56 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that String is pretty much the only case we have where
==is actually faster than===. We could perhaps consider importing the code for==into codegen, if we consider that to be an important consideration.