Ensure Main.eval and Main.include exist in embedded julia #32062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
c42f
force-pushed
the
cjf/fix-embedded-main-include
branch
from
c8d0e12
to
1a78fb9
Compare
|
Yes, I think that's better, I pushed an update. |
JeffBezanson
approved these changes
May 20, 2019
c42f
force-pushed
the
cjf/fix-embedded-main-include
branch
from
1a78fb9
to
2bf916b
Compare
c42f
added
kind:bugfix
4 tasks
These two functions need to be added to Main as part of `jl_init()`, but only when Base is present to avoid bootstrap issues.
c42f
force-pushed
the
cjf/fix-embedded-main-include
branch
from
2bf916b
to
0791d36
Compare
55 tasks
56 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two functions need to be added to Main as part of
jl_init(), but only when Base is present to avoid bootstrap issues.Fixes #28825
Obviously
__preinit_threads__is a weirdly named function to be moving this to, but this part of the init stage seems to be appropriate (ie, right afterjl_add_standard_imports(jl_main_module)). Renaming/cleanup suggestions welcome.