Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inference: fix fieldtype tfunc design #31670

Merged
merged 2 commits into from
Apr 18, 2019
Merged

inference: fix fieldtype tfunc design #31670

merged 2 commits into from
Apr 18, 2019

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Apr 10, 2019

fix #31666 and add some tests for nothrow computation

@vtjnash vtjnash added bugfix This change fixes an existing bug compiler:inference Type inference labels Apr 10, 2019
@vtjnash vtjnash requested a review from Keno April 10, 2019 16:27
@KristofferC KristofferC mentioned this pull request Apr 15, 2019
58 tasks
@vtjnash vtjnash merged commit 3a60e87 into master Apr 18, 2019
@vtjnash vtjnash deleted the jn/31666 branch April 18, 2019 19:33
KristofferC pushed a commit that referenced this pull request Apr 20, 2019
@oschulz
Copy link
Contributor

oschulz commented May 9, 2019

@ararslan , @JeffBezanson : Could this be backported to the upcoming v1.1.1 as well? Or is it too late for that?

@JeffBezanson
Copy link
Member

Should be safe to backport, along with #31848.

@KristofferC
Copy link
Member

1.1.1 is too far in the release process to add anything to.

@ararslan
Copy link
Member

ararslan commented May 9, 2019

Yes, 1.1.1 is frozen; it is effectively finished and will be tagged within a few days.

@oschulz
Copy link
Contributor

oschulz commented May 9, 2019

Sure, I understand, no worries.

@oschulz
Copy link
Contributor

oschulz commented Jul 30, 2019

Would be the a backport candidate for the next Julia LTS release, when the time comes (1.0.x or 1.1.x)?

@ararslan
Copy link
Member

There likely won't be any more 1.1.x releases, but the change will be in 1.2.0. (Indeed it should already be present in the release candidate.) As for 1.0.x, I see no reason not to backport it.

@oschulz
Copy link
Contributor

oschulz commented Jul 30, 2019

Thanks for the info, @ararslan! An eventual backport to 1.0.x would be nice (and I get that 1.1 can't be maintained long term, with 1.2 and 1.3 in the pipeline).

Oh, and yes, we had no more trouble with this since v1.2-rc2.

JeffBezanson pushed a commit that referenced this pull request Feb 20, 2020
KristofferC pushed a commit that referenced this pull request Feb 20, 2020
KristofferC pushed a commit that referenced this pull request Feb 20, 2020
KristofferC pushed a commit that referenced this pull request Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This change fixes an existing bug compiler:inference Type inference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Internal error/MethodError in complex use case
6 participants