remove gc-token from WeakKeyDict #33825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a hold-over from the old iteration protocol, which needed to maintain state between `done` and `next`. The `iteration` function of `Dict` has since been re-written to be safe for concurrent deletions. Replaces: #33756 Co-Authored-By: Hans-Peter Suter <hps@treetron.ch>
JeffBezanson
approved these changes
Nov 12, 2019
|
As it breaks* on v1.3, I think the *tested with v1.3.0-rc4; this PR does fix the problem |
JeffBezanson
pushed a commit
that referenced
this pull request
Nov 13, 2019
This was a hold-over from the old iteration protocol, which needed to maintain state between `done` and `next`. The `iteration` function of `Dict` has since been re-written to be safe for concurrent deletions. Replaces: #33756 Co-Authored-By: Hans-Peter Suter <hps@treetron.ch> (cherry picked from commit 1731d0a)
KristofferC
pushed a commit
that referenced
this pull request
Dec 3, 2019
This was a hold-over from the old iteration protocol, which needed to maintain state between `done` and `next`. The `iteration` function of `Dict` has since been re-written to be safe for concurrent deletions. Replaces: #33756 Co-Authored-By: Hans-Peter Suter <hps@treetron.ch> (cherry picked from commit 1731d0a)
56 tasks
KristofferC
pushed a commit
that referenced
this pull request
Feb 20, 2020
This was a hold-over from the old iteration protocol, which needed to maintain state between `done` and `next`. The `iteration` function of `Dict` has since been re-written to be safe for concurrent deletions. Replaces: #33756 Co-Authored-By: Hans-Peter Suter <hps@treetron.ch> (cherry picked from commit 1731d0a)
KristofferC
pushed a commit
that referenced
this pull request
Feb 20, 2020
This was a hold-over from the old iteration protocol, which needed to maintain state between `done` and `next`. The `iteration` function of `Dict` has since been re-written to be safe for concurrent deletions. Replaces: #33756 Co-Authored-By: Hans-Peter Suter <hps@treetron.ch> (cherry picked from commit 1731d0a)
KristofferC
pushed a commit
that referenced
this pull request
Feb 22, 2020
This was a hold-over from the old iteration protocol, which needed to maintain state between `done` and `next`. The `iteration` function of `Dict` has since been re-written to be safe for concurrent deletions. Replaces: #33756 Co-Authored-By: Hans-Peter Suter <hps@treetron.ch> (cherry picked from commit 1731d0a)
KristofferC
pushed a commit
that referenced
this pull request
Apr 11, 2020
This was a hold-over from the old iteration protocol, which needed to maintain state between `done` and `next`. The `iteration` function of `Dict` has since been re-written to be safe for concurrent deletions. Replaces: #33756 Co-Authored-By: Hans-Peter Suter <hps@treetron.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a hold-over from the old iteration protocol, which needed to maintain state between
doneandnext. Theiterationfunction ofDicthas since been re-written to be safe for concurrent deletions.Replaces: #33756
Co-Authored-By: @swissr