Improve factor some more #1957
Merged
Improve factor some more #1957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1957 +/- ##
==========================================
- Coverage 87.94% 87.93% -0.02%
==========================================
Files 99 99
Lines 36416 36435 +19
==========================================
+ Hits 32027 32040 +13
- Misses 4389 4395 +6 ☔ View full report in Codecov by Sentry. |
lgoettgens
reviewed
Dec 3, 2024
fingolfin
reviewed
Dec 3, 2024
fingolfin
reviewed
Dec 3, 2024
fingolfin
reviewed
Dec 3, 2024
…several types of integer
fingolfin
reviewed
Dec 4, 2024
fingolfin
reviewed
Dec 4, 2024
…est suite accordingly (removed tests of _factor)
fingolfin
approved these changes
Dec 4, 2024
fingolfin
changed the title
fingolfin
reviewed
Dec 4, 2024
fingolfin
changed the title
fingolfin
reviewed
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following advice from @fingolfin the code now uses
flintifyto simplify dispatching.Follow-up to #1951.