Fix root(RealFieldElem(0), 3)
#1965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1965 +/- ##
==========================================
- Coverage 87.93% 87.91% -0.02%
==========================================
Files 99 99
Lines 36467 36471 +4
==========================================
- Hits 32067 32064 -3
- Misses 4400 4407 +7 ☔ View full report in Codecov by Sentry. |
|
P.S.: Test would be good I think. |
fingolfin
force-pushed
the
mh/root-of-real-zero
branch
from
b97688a to
bf8ccf2
Compare
|
Yes 0, oops. Added tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1440
Perhaps there are more issues with RealField and ArbField (actually, I bet there are), but none are made really clear in that issue. This fixes the one concrete issue that was described.