Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

인앱 브라우저 등장 조건, 문구 변경 #438

Merged
merged 3 commits into from
Jan 15, 2023
Merged

인앱 브라우저 등장 조건, 문구 변경 #438

merged 3 commits into from
Jan 15, 2023

Conversation

SeojinSeojin
Copy link
Member

⛓ Related Issues

📋 작업 내용

  • 인앱 브라우저 등장 조건 변경: 로그인되었을 때
  • 인앱 브라우저 관련 문구 변경

📌 PR Point

  • CommonModal의 '확인'자리에 있는 문구를 prop으로 받을 수 있도록 수정했습니다.

@SeojinSeojin SeojinSeojin self-assigned this Jan 15, 2023
@SeojinSeojin SeojinSeojin added the feature 🎄 기능 개발 label Jan 15, 2023
@SeojinSeojin SeojinSeojin linked an issue Jan 15, 2023 that may be closed by this pull request
인앱 브라우저 경고 문구와 등장 조건 변경 #437
Closed
3 tasks
@SeojinSeojin SeojinSeojin removed a link to an issue Jan 15, 2023
인앱 브라우저 경고 문구와 등장 조건 변경 #437
Closed
3 tasks
100Gyeon
100Gyeon approved these changes Jan 15, 2023
View reviewed changes
Copy link
Member

@100Gyeon 100Gyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prop으로 버튼 텍스트 받은 거 좋습니다 !!
작업 속도에 감탄하고 갑니다 역시 너소서 리드👍🏻✨

@SeojinSeojin
Copy link
Member Author

4시 19분에 칼approve 해주는 서윗한 젼언니. ... ....

@SeojinSeojin SeojinSeojin merged commit 002de45 into v1.0.1 Jan 15, 2023
@SeojinSeojin SeojinSeojin deleted the feature/#437 branch January 15, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@100Gyeon 100Gyeon 100Gyeon approved these changes

@NamJwong NamJwong Awaiting requested review from NamJwong

Assignees

@SeojinSeojin SeojinSeojin

Labels
feature 🎄 기능 개발
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SeojinSeojin @100Gyeon @seojin-v6x