feat: Basic submodule support #1875
Merged
+168
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
txemaotero
force-pushed
the
feature/submodule-support
branch
from
ccc8331 to
bf6c453
Compare
CKolkey
reviewed
Dec 11, 2025
Member
|
Great stuff! Small thing re: syntax preference but otherwise fine 👍🏼 |
New functionality:
- When hitting `<cr>` on a submodule entry with changes in the status
view, a new neogit instance is opened with the submodule as root.
- When inside the status view of a submodule, hitting `gp` (default for
the new `GoToParentRepo` mapping) opens a new neogit instance with the
parent repo as root.
Implementation details:
- On new neogit instance creation, information about submodules and
parent repo is cached.
- Helper functions are defined to get the submodule under the cursor or
the parent repo if present.
- New git commands were added to:
- Get a list of the submodules in the repo (in the new
`git/submodule.lua` file)
- Get the path to the parent repo (as a new flag for the `rev_parse`
command)
- The feature was validated manually but a new integration test was also
introduced.
txemaotero
force-pushed
the
feature/submodule-support
branch
from
bf6c453 to
76f470a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to provide some support to work with submodules. It's motivated by the issue #1822
New functionality:
<cr>on a submodule entry with changes in the status view, a new neogit instance is opened with the submodule as root.gp(default for the newGoToParentRepomapping) opens a new neogit instance with the parent repo as root.Implementation details:
git/submodule.luafile)rev_parsecommand)