fix: make neogit respect user's configuration of diffview

[milkias17]

mentioned in #550

[milkias17]

@ten3roberts Any problems with the implementation😅?

[ten3roberts]

I suppose this works by not replacing the table reference, but rather works and mutates the existing reference?

[milkias17]

Yup exactly. We are basically using the exact same method that diffview.nvim uses to merge the default configuration with the users configuration.

[ten3roberts]

Is this all done or is there anything more you want to get in?

Thanks for your help, I'm looking forward to having neogit invoked diffview be consistent with the user invoked diffview 🚀

[milkias17]

Yea interms of repsecting user's configuration that's about it. However the thing mentioned about having a keybinding to invoke the commit popup within the diffview buffer, should I add that or?

[ten3roberts]

Perhaps that feature would be best under a config option, since some people may not want their difftview keybindings to be different and inconsistent. There is an in-progress PR which modifies the config file, so if we do this it would be best as another PR after that one.