Add timing metrics for response to handler in MQ client #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeonDaniel
added a commit
to NeonGeckoCom/neon_speech
that referenced
this pull request
Nov 10, 2023
# Description Handles `client_sent` timestamp and calculates how long it took for the message to be handled in this module # Issues <!-- If this is related to or closes an issue/other PR, please note them here --> # Other Notes NeonGeckoCom/neon_audio#154 Co-authored-by: Daniel McKnight <daniel@neon.ai>
NeonDaniel
added a commit
to NeonGeckoCom/neon-iris
that referenced
this pull request
Nov 10, 2023
NeonDaniel
added a commit
that referenced
this pull request
Nov 15, 2023
# Description Fix speak_ident handling for `klat.response` events Add `response_sent` timing context to API methods Remove listener for incomplete audio playback # Issues Continues #154 # Other Notes <!-- Note any breaking changes, WIP changes, requests for input, etc. here --> --------- Co-authored-by: Daniel McKnight <daniel@neon.ai>
NeonDaniel
added a commit
to NeonGeckoCom/neon-iris
that referenced
this pull request
Nov 21, 2023
* Remove audio resampling moved to neon-speech NeonGeckoCom/neon_speech#180 Closes #28 * Add timing context and logging to go with: NeonGeckoCom/neon_speech#181 NeonGeckoCom/neon_audio#154 * More timing metrics and logging * Refactor timing and add debug log Prevent response error from affecting next input --------- Co-authored-by: Daniel McKnight <daniel@neon.ai>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a timestamp when response is emitted for clients to calculate how long it takes to be handled
Issues
Other Notes
NeonGeckoCom/neon_speech#181