-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Container Improvements, OVOS Compatibility, Optimization, Bugfixes #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update Dockerfile and supporting documentation Use get_messagebus to handle Neon configured messagebus Updated logging * Update mozilla remote dependency version
* Add call to init_config_dir at module load * Refactor to prevent config load on module init * Update requirements spec
NeonDaniel
changed the title
Improved Container Support (#49)
Containerization improvements, Config cleanup
Feb 7, 2022
* Refactor Signal Handling for SignalManager * Refactor signal handler init into main method * Troubleshooting test failures * Add IPC_DIR to signal calls in neon_audio * Cleanup signal manager init * Refactor create_signal and check_for_signal imports * Update neon-utils dependency spec * Resolve unit test errors * Cleanup imports Remove class-level config init Co-authored-by: Daniel McKnight <daniel@neon.ai>
Co-authored-by: Daniel McKnight <daniel@neon.ai>
* Troubleshoot ovos package compatible versions * Troubleshoot ovos package compatible versions * Update unit tests dependency resolution * Remove pinned OPM version in test dependencies * Remove ovos-core dependency * Refactor to deprecate `mycroft` imports * Refactor unit tests to use Neon Messagebus module * Troubleshoot neon-messagebus dependency versions * Troubleshoot dependency versions * Add requests dependency version spec * Update neon-messagebus version spec Co-authored-by: Daniel McKnight <daniel@neon.ai>
Add unit tests for PyPI and Docker builds Co-authored-by: Daniel McKnight <daniel@neon.ai>
* Better default TTS value handling Cleanup `execute` method Add encoded audio files to klat responses * Add missing changes * Fix language handling for profile context * Import Translation and Detection factory methods from OPM Cleanup init to ensure SignalManager is used when available Add libretranslate dependency to docker Co-authored-by: Daniel McKnight <daniel@neon.ai>
* refactor/opm migration to OPM * opm language factories * mimic * audio service from ovos-core * wrapped TTS * tx * dig_for_message * get_multiple_tts * simplify execute * speak multiple langs * remove if * get_neon_local_config * duplicate expanduser call * fix import * Port changes from #58 * Cleanup changes, resolve unit test failures * Update neon-utils dependency spec * Update opm dependency spec Add libretranslate plugin to test deps Handle detect/translate init failures * Add missing Status callback methods Add NeonAudioService to handle passed configuration Add backwards-compat plugin support in get_multiple_tts * Update get_multiple_tts references * Troubleshoot remote tts failure * Handle directory creation to resolve test failure * Refactor TTS translation to match expected Klat returns Add compatibility method _get_tts to WrappedTTS Port changes from #58 * Add back gendered audio handling for local playback * Cleanup get_multiple_tts refactored code Fix rtype error in unit tests Co-authored-by: jarbasai <jarbasai@mailfence.com> Co-authored-by: Daniel McKnight <daniel@neon.ai>
* add license tests and workflow * Add packages from successful neon_speech list * Whitelist self package * Remove vlc dependency to resolve license error * Whitelist neon-api-proxy Co-authored-by: jarbasai <jarbasai@mailfence.com> Co-authored-by: Daniel McKnight <daniel@neon.ai>
* Refactor Docker overlay files Add CLI entrypoints to handle plugin installation in Docker Update requirements * Update espeak apt dependency * Cleanup signal handling Resolve unit test errors * Patch legacy plugin support Reorg Dockerfile to minimize uploaded layer size Co-authored-by: Daniel McKnight <daniel@neon.ai>
* Update dependency specs Update logging Handle cached TTS audio Update `tts` version in Docker for latest coqui plugin * Add python-dateutil license spec * Allow running audio service loading with no services for backwards-compat Add unit test timeout * Add pyparsing license spec Co-authored-by: Daniel McKnight <daniel@neon.ai>
#63) * Move ovos-core dependency to base requirements and update version spec * Update ovos-core dependency spec to release version Co-authored-by: Daniel McKnight <daniel@neon.ai>
NeonDaniel
changed the title
Containerization improvements, Config cleanup
Container Improvements, OVOS Compatibility, Optimization, Bugfixes
May 10, 2022
NeonDaniel
requested review from
NeonBohdan,
NeonJarbas,
NeonKirill and
NeonMariia
May 10, 2022 00:13
NeonDaniel
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved Docker container implementation
Improved Config and Signal handling
Update OVOS module dependencies
Improved Klat response handling
Refactor TTS class on OPM
Handle plugin installation in containers