Skip to content

Commit

Permalink
Update to default escalating volume True for alarms to be audible (#134)
Browse files Browse the repository at this point in the history
Co-authored-by: Daniel McKnight <daniel@neon.ai>
  • Loading branch information
NeonDaniel and NeonDaniel authored Jan 29, 2024
1 parent d84878c commit 6ec1030
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions __init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ def escalate_volume(self) -> bool:
"""
If true, increase volume while alert expiration is playing
"""
return self.preference_skill().get("escalate_volume", False)
return self.preference_skill().get("escalate_volume", True)

@property
def quiet_hours(self) -> bool:
Expand All @@ -170,6 +170,8 @@ def alert_timeout_seconds(self) -> int:
"""
Return the number of seconds to repeat an alert before marking it missed
"""
# TODO: This should be per-type; a user may want an alarm to go off for
# longer than a timer
timeout_minutes = self.preference_skill().get('timeout_min') or 1
if not isinstance(timeout_minutes, int):
LOG.error(f'Invalid `timeout_min` in settings. '
Expand Down Expand Up @@ -1055,7 +1057,7 @@ def _play_notify_expired(self, alert: Alert):
# TODO: refactor to `self.play_audio`
LOG.debug(f"Playing file: {to_play}")
play_audio(to_play).wait(60)
time.sleep(1)
time.sleep(1) # TODO: Skip this and play continuously?
if self.escalate_volume:
self.bus.emit(Message("mycroft.volume.increase"))

Expand Down

0 comments on commit 6ec1030

Please sign in to comment.