Fix the docs in several places #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliotwaite
commented
Dec 14, 2023
| @@ -240,9 +240,9 @@ Produces responses like the following at "/": | |||
|
|
|||
| A2: 139976289979936 | |||
|
|
|||
| B1: 139976289979984 | |||
| B1: 139976289979988 | |||
There was a problem hiding this comment.
This change is to make it easier to tell that these B1 and B2 numbers are different from the B1 and B2 numbers in the first request. Because when I initially tried to compare them, I only compared a few of the initial and end digits, and the numbers looked the same, and I only realized that they were actually different after reviewing them a second time.
|
Hi @elliotwaite |
|
Happy to help where I can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some suggestions I thought of while reading over the docs. If any of the changes are incorrect or unwanted, just let me know and I can revert them to their original version.
P.S. Thanks for creating this web framework! I like a lot of the design decisions you made.