Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add semantic-release. #114

Merged
merged 1 commit into from
Apr 9, 2020
Merged

feat: add semantic-release. #114

merged 1 commit into from
Apr 9, 2020

Conversation

aorinevo
Copy link
Collaborator

@aorinevo aorinevo commented Apr 9, 2020 •
edited
Loading

Changes

  • Add semantic-release
  • Updated /docs/releasing

Notes

@aorinevo aorinevo mentioned this pull request Apr 9, 2020
Closed
aorinevo
aorinevo commented Apr 9, 2020
View reviewed changes
package.json Outdated Show resolved Hide resolved
@aorinevo
Copy link
Collaborator Author

aorinevo commented Apr 9, 2020 •
edited
Loading

@parshap, code changes are complete but we need to add GH_TOKEN secrets to this repo (see https://github.com/NerdWalletOSS/shepherd/settings/secrets).

Otherwise, this PR is ready for review.

@aorinevo aorinevo requested a review from parshap April 9, 2020 14:35
@aorinevo
Copy link
Collaborator Author

aorinevo commented Apr 9, 2020

Created and added GH_TOKEN.

@parshap
Copy link
Contributor

parshap commented Apr 9, 2020

@aorinevo what GH_TOKEN are you using? Also, won't we need an npm token as well for publishing?

@aorinevo
Copy link
Collaborator Author

aorinevo commented Apr 9, 2020

I generated a GH_TOKEN off my account with proper repo perms.

No need for NPM token as publishing is done via travis and only for new tags. Github workflow will take care of CI/CD up to and including tagging. Travis will take over from there and publish to npm.

piperchester
piperchester reviewed Apr 9, 2020
View reviewed changes
Copy link
Contributor

@piperchester piperchester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contrib @aorinevo! Super excited to land this. Just an outstanding comment on GH token management.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
parshap
parshap suggested changes Apr 9, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
parshap
parshap reviewed Apr 9, 2020
View reviewed changes
Copy link
Contributor

@parshap parshap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few other very minor comments.

.travis.yml Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
.releaserc.js Outdated Show resolved Hide resolved
.releaserc.js Outdated Show resolved Hide resolved
@parshap
Copy link
Contributor

parshap commented Apr 9, 2020

Is there something that will "lint" commit messages to help contributors conform to the expectations of semantic-release? The semantic-release readme referenced commitizen or commitlint.

@aorinevo
Copy link
Collaborator Author

aorinevo commented Apr 9, 2020 •
edited
Loading

Is there something that will "lint" commit messages to help contributors conform to the expectations of semantic-release? The semantic-release readme referenced commitizen or commitlint.

The Semantic PR Github app can help with this.

@parshap, can you set that up for this repo as well as enable renovate bot and renovate approve? I've went ahead and enabled Semantic PR app.

References:

parshap
parshap approved these changes Apr 9, 2020
View reviewed changes
Copy link
Contributor

@parshap parshap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My blocking comment was addressed -- feel free to merge once ready!

@aorinevo aorinevo merged commit 4d41c4f into NerdWalletOSS:master Apr 9, 2020
aorinevo pushed a commit that referenced this pull request Apr 9, 2020
@semantic-release-bot
chore(release): 1.5.0
496d97e 
# [1.5.0](v1.4.2...v1.5.0) (2020-04-09)

### Bug Fixes

* missing packages. ([#115](#115)) ([7ace184](7ace184))

### Features

* add semantic release. ([#114](#114)) ([4d41c4f](4d41c4f))
@aorinevo
Copy link
Collaborator Author

aorinevo commented Apr 9, 2020

🎉 This PR is included in version 1.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

jugaltheshah pushed a commit to jugaltheshah/shepherd that referenced this pull request Jan 21, 2021
@aorinevo
feat: add semantic release. (NerdWalletOSS#114)
e0ad59f
jugaltheshah pushed a commit to jugaltheshah/shepherd that referenced this pull request Jan 21, 2021
@semantic-release-bot
chore(release): 1.5.0
0e5bb36 
# [1.5.0](NerdWalletOSS/shepherd@v1.4.2...v1.5.0) (2020-04-09)

### Bug Fixes

* missing packages. ([NerdWalletOSS#115](NerdWalletOSS#115)) ([7ace184](NerdWalletOSS@7ace184))

### Features

* add semantic release. ([NerdWalletOSS#114](NerdWalletOSS#114)) ([4d41c4f](NerdWalletOSS@4d41c4f))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piperchester piperchester piperchester approved these changes

@parshap parshap parshap approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aorinevo @parshap @piperchester