fix: use case-insensitive compare for repo names #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piperchester
approved these changes
May 28, 2020
| return repo1.owner === repo2.owner && repo1.name === repo2.name; | ||
| // GitHub ignores case when differentiating organizations and repos, so we | ||
| // can safely use a case-insensitive compare to make things slightly easier | ||
| // for users who might be using a case-insensitive name on the command line. |
There was a problem hiding this comment.
Nice little rationale here.
aorinevo
pushed a commit
that referenced
this pull request
May 28, 2020
## [1.8.1](v1.8.0...v1.8.1) (2020-05-28) ### Bug Fixes * use case-insensitive compare for repo names ([#192](#192)) ([a9ada15](a9ada15))
|
🎉 This PR is included in version 1.8.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
jugaltheshah
pushed a commit
to jugaltheshah/shepherd
that referenced
this pull request
Jan 21, 2021
jugaltheshah
pushed a commit
to jugaltheshah/shepherd
that referenced
this pull request
Jan 21, 2021
## [1.8.1](NerdWalletOSS/shepherd@v1.8.0...v1.8.1) (2020-05-28) ### Bug Fixes * use case-insensitive compare for repo names ([NerdWalletOSS#192](NerdWalletOSS#192)) ([a9ada15](NerdWalletOSS@a9ada15))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves the experience of using the CLI by making repo names case insensitive. That is, the following two commands will work exactly the same:
cc @taylor-chen