fix: Remove space from .eslintignore filename #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just something small I noticed. Doesn't seem to make a difference when linting though, for some reason. Maybe one of the other eslint configs we're extending is excluding node_modules already. Not sure.
aorinevo
approved these changes
Oct 1, 2021
|
Thanks for the contribution @dbirks! |
aorinevo
pushed a commit
that referenced
this pull request
Oct 1, 2021
## [1.15.3](v1.15.2...v1.15.3) (2021-10-01) ### Bug Fixes * Remove space from .eslintignore filename ([#506](#506)) ([49e0510](49e0510))
|
🎉 This PR is included in version 1.15.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
to dbirks/shepherd
that referenced
this pull request
Oct 1, 2021
## [1.15.2](v1.15.1...v1.15.2) (2021-10-01) ### Bug Fixes * Make semantic-release commit the updated package.json files ([4fbc5d4](4fbc5d4)), closes [/github.com/semantic-release/semantic-release/issues/1593#issuecomment-656866839](https://github.com//github.com/semantic-release/semantic-release/issues/1593/issues/issuecomment-656866839) * Remove engines block from Renovate config ([NerdWalletOSS#505](https://github.com/dbirks/shepherd/issues/505)) ([351b095](351b095)) * Remove space from .eslintignore filename ([NerdWalletOSS#506](https://github.com/dbirks/shepherd/issues/506)) ([49e0510](49e0510))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just something small I noticed. Doesn't seem to make a difference when linting though, for some reason. Maybe one of the other eslint configs we're extending is excluding node_modules already. Not sure.