feat: 添加无法自定义显示天，时，分，秒 #1716
Merged
feat: 添加无法自定义显示天，时，分，秒 #1716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinv8
reviewed
Dec 6, 2023
| @@ -107,8 +109,7 @@ export default class CountdownPage extends Taro.Component { | |||
| | 参数 | 说明 | 类型 | 可选值 | 默认值 | | |||
| | ---------- | ------- | ------- | ----| -------- | | |||
| | isCard | 是否显示卡片式样式 | Boolean | - | false | | |||
| | isShowDay | 是否显示天数 | Boolean | - | false | | |||
| | isShowHour | 是否显示小时 | Boolean | - | true | | |||
| | showFieldNames | 自定义显示天，时，分，秒 | Object | - | `isShowDay:false,isShowHour:true,isShowMinute:true,isShowSecond:true` | | |||
There was a problem hiding this comment.
此处变动可能引起版本兼容性问题，建议增加 isShowMinute 即可
There was a problem hiding this comment.
现在已经按照建议改为只添加isShowMinute了
robinv8
approved these changes
Dec 10, 2023
robinv8
pushed a commit
that referenced
this pull request
Dec 11, 2023
* fix: 修复无法自定义显示天，时，分，秒 * fix: 修复calculateTime * fix: 只添加isShowMinute
robinv8
added a commit
that referenced
this pull request
Dec 11, 2023
This was referenced Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
目前版本只支持自定义显示天、时，没有支持自定义显示分、秒，
而只显示秒在业务场景中十分常见，故添加此修复