fix(router): 修复navigateBack的传参错误，添加错误提示

NervJS · Dec 10, 2018 · 55f9aed · 55f9aed
1 parent 1e7dc10
commit 55f9aed
Showing 1 changed file with 13 additions and 3 deletions.
diff --git a/packages/taro-router/src/apis/index.ts b/packages/taro-router/src/apis/index.ts
@@ -1,4 +1,5 @@
 import { History } from '../utils/types'
+import invariant from 'invariant';
 
 type SuccessCallback = (res: any) => any
 type FailCallback = (err: any) => any
@@ -27,6 +28,9 @@ interface RedirectToOption {
 
 const createNavigateTo = (history: History) => {
   return function ({ url }: NavigateToOption) {
+
+    invariant(url, 'navigateTo must be called with a url')
+
     try {
       if (/^(https?:)\/\//.test(url)) {
         window.location.assign(url);
@@ -40,10 +44,13 @@ const createNavigateTo = (history: History) => {
 }
 
 const createNavigateBack = (history: History) => {
-  return function (opts: NavigateBackOption = { delta: -1 }) {
+  return function (opts: NavigateBackOption = {}) {
     try {
-      const { delta = -1 } = opts
-      history.go(delta)
+      const { delta = 1 } = opts
+
+      invariant(delta >= 0, 'navigateBack must be called with a delta greater than 0')
+
+      history.go(-delta)
       return Promise.resolve()
     } catch (e) {
       return Promise.reject()
@@ -53,6 +60,9 @@ const createNavigateBack = (history: History) => {
 
 const createRedirectTo = (history: History) => {
   return function ({ url }: RedirectToOption) {
+
+    invariant(url, 'redirectTo must be called with a url')
+
     if (/^(https?:)\/\//.test(url)) {
       window.location.assign(url);
     }