Merge pull request #1722 from pacoyang/fix-textarea-input

fix(taro-components): 修复 Textarea 组件无法传递 detail 问题
NervJS · Jan 7, 2019 · e542bdf · e542bdf
2 parents d512b3e + 0eb64cf
commit e542bdf
Showing 1 changed file with 6 additions and 8 deletions.
diff --git a/packages/taro-components/src/components/textarea/index.js b/packages/taro-components/src/components/textarea/index.js
@@ -3,21 +3,19 @@ import omit from 'omit.js'
 class Textarea extends Nerv.Component {
   constructor () {
     super(...arguments)
+    this.onChange = this.onChange.bind(this)
   }
 
   onChange (e) {
-    const { onChange, onInput } = this.props
+    const { onChange = '', onInput = '' } = this.props
     Object.defineProperty(e, 'detail', {
       enumerable: true,
       value: {
         value: e.target.value
       }
     })
-    if (onChange) {
-      onChange && onChange(e)
-    } else {
-      onInput && onInput(e)
-    }
+    if (onChange) return onChange && onChange(e)
+    if (onInput) return onInput && onInput(e)
   }
 
   render () {
@@ -26,7 +24,6 @@ class Textarea extends Nerv.Component {
       placeholder = '',
       disabled,
       maxlength = 140,
-      onChange,
       onFocus,
       onBlur,
       autoFocus = false
@@ -39,6 +36,7 @@ class Textarea extends Nerv.Component {
           'disabled',
           'maxlength',
           'onChange',
+          'onInput',
           'onFocus',
           'onBlur',
           'autofocus'
@@ -48,7 +46,7 @@ class Textarea extends Nerv.Component {
         disabled={disabled}
         maxlength={maxlength}
         autofocus={autoFocus}
-        onChange={onChange}
+        onChange={this.onChange}
         onFocus={onFocus}
         onBlur={onBlur}
       />