Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

h5的Taro.createAnimation单位问题 #2749

Closed
zWingz opened this issue Apr 12, 2019 · 2 comments · Fixed by #2755
Closed

h5的Taro.createAnimation单位问题 #2749

zWingz opened this issue Apr 12, 2019 · 2 comments · Fixed by #2755
Assignees

Comments

@zWingz
Copy link
Contributor

zWingz commented Apr 12, 2019

源码

根据源码描述, 这里的单位默认是px
后续所有ani方法都直接使用+this.unit, 例如left

left (value) {
    this.rules.push(`left: ${value}${this.unit}`)
    return this
  }

这样可能导致我传入的left = 10%, 这时候解析的是left: 10%px.
因为不确实是否故意而为, 所以先提issues, 后续可以提pr

@taro-bot
Copy link

taro-bot bot commented Apr 12, 2019

欢迎提交 Issue~

如果你提交的是 bug 报告,请务必遵循 Issue 模板的规范,尽量用简洁的语言描述你的问题,最好能提供一个稳定简单的复现。🙏🙏🙏

如果你的信息提供过于模糊或不足,或者已经其他 issue 已经存在相关内容,你的 issue 有可能会被关闭。

Good luck and happy coding~

@taro-bot
Copy link

taro-bot bot commented Apr 13, 2019

CC @Littly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants