Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): Image heightFix no work #11455

Merged
merged 5 commits into from
Apr 6, 2022
Merged

fix(components): Image heightFix no work #11455

merged 5 commits into from
Apr 6, 2022

Conversation

tangbzai
Copy link
Contributor

@tangbzai tangbzai commented Mar 15, 2022 •
edited
Loading

这个 PR 做了什么? (简要描述所做更改)

修复 Image 组件 mode 设置为 heightFix 时无效的问题

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue id #

这个 PR 涉及以下平台:

  • Web 平台（H5）

@taro-bot2
Copy link

taro-bot2 bot commented Mar 15, 2022

欢迎提交 PR~ Taro 非常感谢您对开源事业做出的贡献！🌷🌷🌷

一般 PR 会在一到两周内进行 review，成功合入后会随下一个版本进行发布。

Review 需要耗费大量时间，所以请遵循以下规范，协助我们提高 review 效率🙏🙏🙏

  1. 详细介绍 PR 的背景（非常重要，例如解决了什么问题，该问题如何复现等）
  2. 确保 CI 顺利运行。
  3. 最好能提供对应的测试用例。

为了更好地进行沟通，请加入 Taro 开发者微信群：

@ZakaryCode ZakaryCode added A-components Area - H5 组件库相关 T-h5 Target - 编译到 H5 labels Mar 15, 2022
@taro-bot2 taro-bot2 bot mentioned this pull request Mar 19, 2022
Closed
ZakaryCode
ZakaryCode requested changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@ZakaryCode ZakaryCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

组件内也需要同步修改

https://github.com/NervJS/taro/blob/next/packages/taro-components/src/components/image/image.tsx#L10

@tangbzai tangbzai requested a review from ZakaryCode April 1, 2022 01:27
@taro-bot2 taro-bot2 bot mentioned this pull request Apr 2, 2022
Closed
ZakaryCode
ZakaryCode approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@ZakaryCode ZakaryCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢贡献

@ZakaryCode ZakaryCode modified the milestones: 3.4.6, 3.4.5 Apr 6, 2022
@ZakaryCode ZakaryCode merged commit cf34f96 into NervJS:next Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZakaryCode ZakaryCode ZakaryCode approved these changes

Assignees
No one assigned
Labels
A-components Area - H5 组件库相关 T-h5 Target - 编译到 H5
Projects
H5
Archived in project
Milestone
3.4.5
Development

Successfully merging this pull request may close these issues.
2 participants
@tangbzai @ZakaryCode