Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove Vue peer dependence to fix that Vue will be installed at React Taro project and it will leads to JSX Incompatible element type #11541

Closed
wants to merge 0 commits into from

Conversation

imnot2
Copy link

@imnot2 imnot2 commented Mar 30, 2022

这个 PR 做了什么? (简要描述所做更改)
去掉peerDepenence里的vue,它会在一些React Taro项目当中被安装,从而导致JSX.Element 类型不匹配

这个 PR 是什么类型? (至少选择一个)

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)

@taro-bot2
Copy link

taro-bot2 bot commented Mar 30, 2022

欢迎提交 PR~ Taro 非常感谢您对开源事业做出的贡献!🌷🌷🌷

一般 PR 会在一到两周内进行 review,成功合入后会随下一个版本进行发布。

Review 需要耗费大量时间,所以请遵循以下规范,协助我们提高 review 效率🙏🙏🙏

  1. 详细介绍 PR 的背景(非常重要,例如解决了什么问题,该问题如何复现等)
  2. 确保 CI 顺利运行。
  3. 最好能提供对应的测试用例。

为了更好地进行沟通,请加入 Taro 开发者微信群:

@imnot2 imnot2 changed the title fix(#11474) fix: Remove Vue dependence in peer to fix that Vue will be installed at React Taro project, it will leads to JSX Incompatible element type Mar 30, 2022
@imnot2 imnot2 changed the title fix: Remove Vue dependence in peer to fix that Vue will be installed at React Taro project, it will leads to JSX Incompatible element type fix: Remove Vue dependence in peer to fix that Vue will be installed at React Taro project and it will leads to JSX Incompatible element type Mar 30, 2022
@imnot2 imnot2 changed the title fix: Remove Vue dependence in peer to fix that Vue will be installed at React Taro project and it will leads to JSX Incompatible element type fix: Remove Vue peer dependence to fix that Vue will be installed at React Taro project and it will leads to JSX Incompatible element type Mar 30, 2022
@imnot2 imnot2 closed this Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant