Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(h5): stencil slot 与 react render冲突问题 #11379 #11744

Merged
merged 1 commit into from
May 5, 2022
Merged

fix(h5): stencil slot 与 react render冲突问题 #11379 #11744

merged 1 commit into from
May 5, 2022

Conversation

baosiqing
Copy link
Collaborator

@baosiqing baosiqing commented Apr 29, 2022 •
edited by ZakaryCode
Loading

这个 PR 做了什么? (简要描述所做更改)
解决原有处理stencil slot与react render冲突时删除注释节点引起的vue中语法失效的问题，改为判断是否是stencil插入的节点，并将其中的属性变更

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue id fix H5 v-if 报错 #11379
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他，请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台（QuickApp）
  • Web 平台（H5）
  • 移动端（React-Native）

@taro-bot2 taro-bot2 bot mentioned this pull request Apr 30, 2022
Closed
@ZakaryCode ZakaryCode added the T-h5 Target - 编译到 H5 label May 1, 2022
@ZakaryCode ZakaryCode merged commit 3e8c8eb into next May 5, 2022
@ZakaryCode ZakaryCode deleted the fix/stencil-render branch May 5, 2022 11:49
@taro-bot2 taro-bot2 bot mentioned this pull request May 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZakaryCode ZakaryCode ZakaryCode approved these changes

Assignees
No one assigned
Labels
T-h5 Target - 编译到 H5
Projects
H5
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

H5 v-if 报错
2 participants
@baosiqing @ZakaryCode