Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(router-rn): tabbar 调整为 reletive 定位，撑起页面高度 (#12404) #12405

Merged
merged 1 commit into from
Aug 30, 2022
Merged

fix(router-rn): tabbar 调整为 reletive 定位，撑起页面高度 (#12404) #12405

merged 1 commit into from
Aug 30, 2022

Conversation

biorz
Copy link
Member

@biorz biorz commented Aug 30, 2022 •
edited
Loading

这个 PR 做了什么? (简要描述所做更改)
tabbar 需要撑起页面高度，与其他端保持一致。 issue

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue: fix #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他，请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台（QuickApp）
  • Web 平台（H5）
  • 移动端（React-Native）

@biorz biorz requested review from yechunxi and zhiqingchen and removed request for yechunxi August 30, 2022 06:21
@yechunxi
Copy link
Collaborator

@biorz 这里我测下来并没有效果，你demo完善下?

@biorz
Copy link
Member Author

biorz commented Aug 30, 2022 •
edited
Loading

@biorz 这里我测下来并没有效果，你demo完善下?

忘记 push 了， 在看下呢 😅 @yechunxi

@yechunxi yechunxi merged commit d11af94 into NervJS:next Aug 30, 2022
@zhiqingchen zhiqingchen mentioned this pull request Sep 1, 2022
Merged
@taro-bot2 taro-bot2 bot mentioned this pull request Sep 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yechunxi yechunxi yechunxi approved these changes

@zhiqingchen zhiqingchen Awaiting requested review from zhiqingchen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@biorz @yechunxi