fix(postcss): pxtransform baseFontSize 取值问题 #12460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
欢迎提交 PR~ Taro 非常感谢您对开源事业做出的贡献！🌷🌷🌷 一般 PR 会在一到两周内进行 review，成功合入后会随下一个版本进行发布。 Review 需要耗费大量时间，所以请遵循以下规范，协助我们提高 review 效率🙏🙏🙏
为了更好地进行沟通，请加入 Taro 开发者微信群： |
|
对应的测试用例还是得加一下的～ |
ZakaryCode
requested changes
Sep 8, 2022
There was a problem hiding this comment.
webpack-runner、webpack5-runner 中有同样的问题，也需要同步修改
另外如果可以帮忙补充一下测试用例就太好了
iamlinsfans
force-pushed
the
fix_postcss-pxtransform-basefontsize
branch
from
091b349 to
014851c
Compare
pxtransform 这个测试用例已经添加，webpack-runne、webpack5-runner 这两个的测试用例不知道加在哪里 |
This was referenced Sep 10, 2022
KkZsc
pushed a commit
to KkZsc/taro
that referenced
this pull request
Dec 5, 2022
Co-authored-by: 林纪莹 <linjiying@suredoc.cn> Co-authored-by: Zakary <zakarycode@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这个 PR 做了什么? (简要描述所做更改)
这个 PR 是什么类型? (至少选择一个)
这个 PR 涉及以下平台: