fix: 优化路由接口以及修复onResize回调参数缺失的字段 #14967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guoenxuan
force-pushed
the
mpharmony-gex-route
branch
from
1f14ed9 to
27de8e1
Compare
guoenxuan
force-pushed
the
mpharmony-gex-route
branch
2 times, most recently
from
3371bdb to
37e9ab8
Compare
guoenxuan
force-pushed
the
mpharmony-gex-route
branch
from
37e9ab8 to
4f41c13
Compare
ZakaryCode
requested changes
Dec 27, 2023
| const originPath = routesAlias.getOrigin(pathPieces.pathname) | ||
| const pagePath = originPath.startsWith('/') ? originPath.substring(1) : originPath | ||
| if (!RouterConfig.pages.includes(pagePath)) { | ||
| const res = { errMsg: `${method}:fail page ${pagePath} is not found` } |
There was a problem hiding this comment.
这里参考了微信小程序的行为。微信小程序在用路由函数跳转到不存在的页面时，并不会触发onPageNotFound 事件，而是返回了错误信息。
packages/taro-router/src/api.ts
Outdated
| fail?.(res) | ||
| complete?.(res) | ||
| reject(res) | ||
| return |
There was a problem hiding this comment.
如果 fail 或 compete 是 function，这里应该 return resolve(res)，反之则为 return reject(res)，下面的 catch 中也存在类似问题
guoenxuan
force-pushed
the
mpharmony-gex-route
branch
2 times, most recently
from
84c6ba8 to
084694f
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #14967 +/- ##
==========================================
- Coverage 58.94% 58.89% -0.05%
==========================================
Files 489 489
Lines 21681 21698 +17
Branches 5556 5566 +10
==========================================
Hits 12780 12780
- Misses 7724 7741 +17
Partials 1177 1177
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这个 PR 做了什么? (简要描述所做更改)
这个 PR 是什么类型? (至少选择一个)
这个 PR 涉及以下平台: