Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: taro-componnets-react 新增Icon组件 #15170

Merged
merged 2 commits into from
Jan 27, 2024
Merged

Conversation

ZEJIA-LIU
Copy link
Contributor

@ZEJIA-LIU ZEJIA-LIU commented Jan 25, 2024

这个 PR 做了什么? (简要描述所做更改)
为 taro-component-react 新增了Icon 组件

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue: fix #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他,请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)
  • 鸿蒙(harmony)

Copy link

taro-bot2 bot commented Jan 25, 2024

欢迎提交 PR~ Taro 非常感谢您对开源事业做出的贡献!🌷🌷🌷

一般 PR 会在一到两周内进行 review,成功合入后会随下一个版本进行发布。

Review 需要耗费大量时间,所以请遵循以下规范,协助我们提高 review 效率🙏🙏🙏

  1. 详细介绍 PR 的背景(非常重要,例如解决了什么问题,该问题如何复现等)
  2. 确保 CI 顺利运行。
  3. 最好能提供对应的测试用例。

为了更好地进行沟通,请加入 Taro 开发者微信群:

Copy link

codecov bot commented Jan 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2aacda8) 45.84% compared to head (f1232cf) 59.38%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #15170       +/-   ##
===========================================
+ Coverage   45.84%   59.38%   +13.54%     
===========================================
  Files         350      487      +137     
  Lines       13103    21490     +8387     
  Branches     2903     5491     +2588     
===========================================
+ Hits         6007    12762     +6755     
- Misses       4582     7560     +2978     
+ Partials     2514     1168     -1346     
Flag Coverage Δ
taro-cli 63.29% <ø> (ø)
taro-runner 46.21% <ø> (ø)
taro-runtime 65.51% <ø> (ø)
taro-web 41.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 339 files with indirect coverage changes

@ZakaryCode ZakaryCode merged commit ff931a2 into main Jan 27, 2024
25 checks passed
@ZakaryCode ZakaryCode deleted the feat/ssr-component-icon branch January 27, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants