-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
types: 修改request请求api的complete res参数类型,与success一致 #15392
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 similar comments
ZakaryCode
requested changes
May 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15392 +/- ##
========================================
Coverage 58.64% 58.64%
========================================
Files 500 500
Lines 21936 21936
Branches 5537 5578 +41
========================================
Hits 12865 12865
- Misses 7928 8130 +202
+ Partials 1143 941 -202
Flags with carried forward coverage won't be shown. Click here to find out more. |
This was referenced May 4, 2024
ZakaryCode
approved these changes
May 6, 2024
ZakaryCode
force-pushed
the
fix/types/api.request
branch
2 times, most recently
from
May 7, 2024 07:13
abbf826
to
2a30d45
Compare
ZEJIA-LIU
approved these changes
May 7, 2024
ZakaryCode
force-pushed
the
fix/types/api.request
branch
from
May 7, 2024 08:21
2a30d45
to
68b21d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这个 PR 做了什么? (简要描述所做更改)
修改taro api request的complete配置中res的参数类型,这个类型与successCallback是一致的:
这个 PR 是什么类型? (至少选择一个)
这个 PR 涉及以下平台: