Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 适配微信 Skyline 组件 #15549

Merged
merged 25 commits into from
Apr 29, 2024
Merged

feat: 适配微信 Skyline 组件 #15549

merged 25 commits into from
Apr 29, 2024

Conversation

koppthe
Copy link
Contributor

@koppthe koppthe commented Apr 20, 2024

这个 PR 做了什么? (简要描述所做更改)

新增微信小程序 Skyline 的组件适配(不包含手势相关的组件)

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue: fix #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他,请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)
  • 鸿蒙(harmony)

Copy link

taro-bot2 bot commented Apr 20, 2024

欢迎提交 PR~ Taro 非常感谢您对开源事业做出的贡献!🌷🌷🌷

一般 PR 会在一到两周内进行 review,成功合入后会随下一个版本进行发布。

Review 需要耗费大量时间,所以请遵循以下规范,协助我们提高 review 效率🙏🙏🙏

  1. 详细介绍 PR 的背景(非常重要,例如解决了什么问题,该问题如何复现等)
  2. 确保 CI 顺利运行。
  3. 最好能提供对应的测试用例。

为了更好地进行沟通,请加入 Taro 开发者微信群:

1 similar comment
Copy link

taro-bot2 bot commented Apr 20, 2024

欢迎提交 PR~ Taro 非常感谢您对开源事业做出的贡献!🌷🌷🌷

一般 PR 会在一到两周内进行 review,成功合入后会随下一个版本进行发布。

Review 需要耗费大量时间,所以请遵循以下规范,协助我们提高 review 效率🙏🙏🙏

  1. 详细介绍 PR 的背景(非常重要,例如解决了什么问题,该问题如何复现等)
  2. 确保 CI 顺利运行。
  3. 最好能提供对应的测试用例。

为了更好地进行沟通,请加入 Taro 开发者微信群:

* main:
  chore: fix lint
  fix: 增加 modifyAppConfig 钩子,修复引用抖音小程序内置页面的问题, close #15388
  chore(release): publish 3.6.27 (#15536)
  fix: 修复安装全插件不支持传入 registry 的问题 (#15537)
  fix: 修改customRoutes配置路径缺失问题,补充转发情况

# Conflicts:
#	pnpm-lock.yaml
@ZEJIA-LIU ZEJIA-LIU marked this pull request as draft April 23, 2024 03:04
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.64%. Comparing base (3a4b002) to head (d2298f1).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #15549      +/-   ##
==========================================
+ Coverage   58.52%   58.64%   +0.11%     
==========================================
  Files         491      500       +9     
  Lines       21885    21936      +51     
  Branches     5621     5621              
==========================================
+ Hits        12809    12865      +56     
+ Misses       7911     7887      -24     
- Partials     1165     1184      +19     
Flag Coverage Δ
taro-cli 63.61% <ø> (+6.21%) ⬆️
taro-runner 46.31% <100.00%> (+0.06%) ⬆️
taro-runtime 65.35% <ø> (ø)
taro-web 40.62% <100.00%> (+0.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...src/components/draggable-sheet/draggable-sheet.tsx 100.00% <100.00%> (ø)
...nents/src/components/grid-builder/grid-builder.tsx 100.00% <100.00%> (ø)
...nents/src/components/list-builder/list-builder.tsx 100.00% <100.00%> (ø)
...mponents/nested-scroll-body/nested-scroll-body.tsx 100.00% <100.00%> (ø)
...ents/nested-scroll-header/nested-scroll-header.tsx 100.00% <100.00%> (ø)
...s/src/components/open-container/open-container.tsx 100.00% <100.00%> (ø)
...kages/taro-components/src/components/span/span.tsx 100.00% <100.00%> (ø)
...ner/src/__tests__/fixtures/skyline/babel.config.js 100.00% <100.00%> (ø)
...ackages/taro-mini-runner/src/plugins/MiniPlugin.ts 69.95% <ø> (+0.64%) ⬆️
...ner/src/__tests__/fixtures/skyline/babel.config.js 100.00% <ø> (ø)

... and 12 files with indirect coverage changes

@koppthe koppthe requested a review from ZEJIA-LIU April 25, 2024 06:54
@ZEJIA-LIU ZEJIA-LIU marked this pull request as ready for review April 25, 2024 09:26
@koppthe koppthe merged commit d99ed0c into main Apr 29, 2024
26 of 27 checks passed
@koppthe koppthe deleted the feat/skyline-adaptive branch April 29, 2024 08:33
This was referenced May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants