Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复自定义路由的跳转问题 #15658

Merged
merged 3 commits into from
May 10, 2024
Merged

fix: 修复自定义路由的跳转问题 #15658

merged 3 commits into from
May 10, 2024

Conversation

ZEJIA-LIU
Copy link
Contributor

这个 PR 做了什么? (简要描述所做更改)
修复自定义路由的跳转问题

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue: fix #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他,请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)
  • 鸿蒙(harmony)

Copy link

taro-bot2 bot commented May 7, 2024

欢迎提交 PR~ Taro 非常感谢您对开源事业做出的贡献!🌷🌷🌷

一般 PR 会在一到两周内进行 review,成功合入后会随下一个版本进行发布。

Review 需要耗费大量时间,所以请遵循以下规范,协助我们提高 review 效率🙏🙏🙏

  1. 详细介绍 PR 的背景(非常重要,例如解决了什么问题,该问题如何复现等)
  2. 确保 CI 顺利运行。
  3. 最好能提供对应的测试用例。

为了更好地进行沟通,请加入 Taro 开发者微信群:

1 similar comment
Copy link

taro-bot2 bot commented May 7, 2024

欢迎提交 PR~ Taro 非常感谢您对开源事业做出的贡献!🌷🌷🌷

一般 PR 会在一到两周内进行 review,成功合入后会随下一个版本进行发布。

Review 需要耗费大量时间,所以请遵循以下规范,协助我们提高 review 效率🙏🙏🙏

  1. 详细介绍 PR 的背景(非常重要,例如解决了什么问题,该问题如何复现等)
  2. 确保 CI 顺利运行。
  3. 最好能提供对应的测试用例。

为了更好地进行沟通,请加入 Taro 开发者微信群:

Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 58.62%. Comparing base (c76a103) to head (905459b).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #15658      +/-   ##
==========================================
+ Coverage   58.61%   58.62%   +0.01%     
==========================================
  Files         500      500              
  Lines       21957    21943      -14     
  Branches     5530     5593      +63     
==========================================
- Hits        12871    12865       -6     
+ Misses       8138     7992     -146     
- Partials      948     1086     +138     
Flag Coverage Δ
taro-cli 75.00% <ø> (ø)
taro-runner 54.00% <ø> (ø)
taro-runtime 79.39% <ø> (ø)
taro-web 44.66% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/taro-router/src/router/index.ts 23.52% <ø> (ø)
packages/taro-router/src/router/navigation-bar.ts 4.39% <0.00%> (ø)
packages/taro-router/src/router/page.ts 5.24% <0.00%> (-2.13%) ⬇️
packages/taro-router/src/api.ts 18.44% <0.00%> (+0.35%) ⬆️

... and 45 files with indirect coverage changes

@nolanlee
Copy link

nolanlee commented May 9, 2024

请问预计什么时候会发布这个 bug fix 的版本? @ZEJIA-LIU

@ZEJIA-LIU
Copy link
Contributor Author

请问预计什么时候会发布这个 bug fix 的版本? @ZEJIA-LIU

本周五

@koppthe koppthe merged commit 2854bba into main May 10, 2024
25 of 26 checks passed
@koppthe koppthe deleted the fix/custom-router branch May 10, 2024 05:58
} else {
return reject(res)
}
if (!RouterConfig.isPage(addLeadingSlash(option.url))) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ZEJIA-LIU 如果 url 携带了参数会匹配不到

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants