Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react): 小程序开发支持config传入的appId #15835

Merged
merged 4 commits into from
Jul 10, 2024

Conversation

yechunxi
Copy link
Collaborator

@yechunxi yechunxi commented Jun 3, 2024

这个 PR 做了什么? (简要描述所做更改)

react开发中,小程序支持config传入的appId

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue: fix #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他,请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)
  • 鸿蒙(harmony)

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.51%. Comparing base (59ab4cf) to head (cc45e74).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #15835   +/-   ##
=======================================
  Coverage   56.51%   56.51%           
=======================================
  Files         500      500           
  Lines       22767    22767           
  Branches     5641     5640    -1     
=======================================
  Hits        12866    12866           
- Misses       8666     8673    +7     
+ Partials     1235     1228    -7     
Flag Coverage Δ
taro-cli 49.22% <ø> (ø)
taro-runner 49.22% <ø> (-4.79%) ⬇️
taro-runtime 79.39% <ø> (+30.17%) ⬆️
taro-web 40.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@ZakaryCode
Copy link
Contributor

修改本身没问题,不过 4.x 分支调整了下 react 插件路径,另外 solid 插件应该也需要同步下变更。

@ZEJIA-LIU 佳哥得空帮忙跟进看看~

@ZEJIA-LIU ZEJIA-LIU modified the milestones: 3.6.30, 3.6.32 Jun 4, 2024
@zhiqingchen zhiqingchen merged commit 96c8652 into NervJS:main Jul 10, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants