Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复solid的onShow,onHide不生效的bug #16569

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

phy-lei
Copy link
Contributor

@phy-lei phy-lei commented Sep 21, 2024

这个 PR 做了什么? (简要描述所做更改)
修复onShow,onHide不生效的问题

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue: fix #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他,请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)
  • 鸿蒙(harmony)

Copy link

codecov bot commented Sep 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.51%. Comparing base (ad13357) to head (8503ab8).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #16569   +/-   ##
=======================================
  Coverage   58.51%   58.51%           
=======================================
  Files         466      466           
  Lines       27115    27115           
  Branches     5967     5931   -36     
=======================================
  Hits        15866    15866           
+ Misses       9773     9770    -3     
- Partials     1476     1479    +3     
Flag Coverage Δ
taro-cli 73.67% <ø> (ø)
taro-runtime 59.83% <ø> (ø)
taro-web 52.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

This was referenced Sep 28, 2024
@ZEJIA-LIU ZEJIA-LIU self-requested a review October 8, 2024 05:56
@ZEJIA-LIU ZEJIA-LIU merged commit 5148dd6 into NervJS:main Oct 8, 2024
23 checks passed
This was referenced Oct 12, 2024
koppthe added a commit that referenced this pull request Oct 15, 2024
* main:
  fix: 修复solid的onShow,onHide不生效的bug (#16569)
  fix(taro-cli): 修正tsconfig-paths-webpack-plugin插件的导入条件
  fix(taro-cli): 使TS条件下生成的模板,import与export间保持一行空隙,以避免ESLint报错
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants