-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 修复solid的onShow,onHide不生效的bug #16569
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16569 +/- ##
=======================================
Coverage 58.51% 58.51%
=======================================
Files 466 466
Lines 27115 27115
Branches 5967 5931 -36
=======================================
Hits 15866 15866
+ Misses 9773 9770 -3
- Partials 1476 1479 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
This was referenced Sep 28, 2024
ZEJIA-LIU
approved these changes
Oct 8, 2024
This was referenced Oct 12, 2024
koppthe
added a commit
that referenced
this pull request
Oct 15, 2024
* main: fix: 修复solid的onShow,onHide不生效的bug (#16569) fix(taro-cli): 修正tsconfig-paths-webpack-plugin插件的导入条件 fix(taro-cli): 使TS条件下生成的模板,import与export间保持一行空隙,以避免ESLint报错
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这个 PR 做了什么? (简要描述所做更改)
修复onShow,onHide不生效的问题
这个 PR 是什么类型? (至少选择一个)
这个 PR 涉及以下平台: