Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(taro-cli): 修复默认项目模板中存在的一些问题 #16600

Merged
merged 3 commits into from
Sep 29, 2024

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Sep 25, 2024

这个 PR 做了什么? (简要描述所做更改)

修复默认项目模板中存在的一些问题:

使TS条件下生成的模板中的dev和prod的配置文件,import与export间保持一行空隙,以避免ESLint报错
修正tsconfig-paths-webpack-plugin插件的导入条件,在配置中为TS且非vite,但导入为TS,统一一下配置

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue: fix #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他,请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)
  • 鸿蒙(harmony)

@skyclouds2001 skyclouds2001 changed the title Fix(taro-cli): 修复默认项目模板中存在的一些问题 fix(taro-cli): 修复默认项目模板中存在的一些问题 Sep 25, 2024
@skyclouds2001 skyclouds2001 marked this pull request as ready for review September 25, 2024 17:27
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.51%. Comparing base (4bb4d2b) to head (a7b08bc).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main   #16600    +/-   ##
========================================
  Coverage   58.51%   58.51%            
========================================
  Files         466      466            
  Lines       27115    27115            
  Branches     5715     5911   +196     
========================================
  Hits        15866    15866            
- Misses       9768     9797    +29     
+ Partials     1481     1452    -29     
Flag Coverage Δ
taro-cli 73.67% <ø> (ø)
taro-runtime 59.83% <ø> (ø)
taro-web 52.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 18 files with indirect coverage changes

This was referenced Sep 28, 2024
@luckyadam luckyadam merged commit ad13357 into NervJS:main Sep 29, 2024
23 checks passed
@skyclouds2001 skyclouds2001 deleted the fix/template branch September 29, 2024 14:32
This was referenced Oct 5, 2024
@ZEJIA-LIU ZEJIA-LIU added this to the 4.0.7 milestone Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants