-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(babel-preset-taro): 配置中使用了不正确的插件 #16726
Open
skyclouds2001
wants to merge
2
commits into
NervJS:main
Choose a base branch
from
skyclouds2001:babel-class-properties-plugin
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix(babel-preset-taro): 配置中使用了不正确的插件 #16726
skyclouds2001
wants to merge
2
commits into
NervJS:main
from
skyclouds2001:babel-class-properties-plugin
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyclouds2001
changed the title
fix: babel plugin incorrect usage bug
fix(babel-preset-taro): 不正确的插件使用
Oct 17, 2024
skyclouds2001
changed the title
fix(babel-preset-taro): 不正确的插件使用
fix(babel-preset-taro): 配置中使用了不正确的插件
Oct 17, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16726 +/- ##
========================================
Coverage 58.51% 58.51%
========================================
Files 466 466
Lines 27115 27115
Branches 5951 5912 -39
========================================
Hits 15866 15866
- Misses 9739 9899 +160
+ Partials 1510 1350 -160
Flags with carried forward coverage won't be shown. Click here to find out more.
|
18 tasks
skyclouds2001
commented
Oct 21, 2024
This was referenced Oct 26, 2024
This was referenced Oct 26, 2024
This was referenced Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这个 PR 做了什么? (简要描述所做更改)
更新 babel 使用的插件名称
@babel/plugin-proposal-class-properties 插件已弃用,应采用 @babel/plugin-transform-class-properties
注意到 package.json 中已更新使用新插件,但 index.js 中尚未更新使用新插件
查看提交记录注意到对应插件已在 2ca1ce59c49d7900f6a098165299c2c52ea0548d 提交中更新为新插件,但在 c7688632f566016465e257756707acafbac604a6 中意外地恢复为弃用的原插件(但未恢复 package.json 中的)
在合并该 PR 后,就可以回退 5400d1f4bd538bdb5e022e0a3abccb92f1483826,从项目模板中移除该弃用的插件,参见 #16727
Note
考虑到该插件已被包含在
@babel/preset-env
中,未来可以考虑移除该插件同时参见文档更新 NervJS/taro-docs#284
这个 PR 是什么类型? (至少选择一个)
这个 PR 涉及以下平台: