-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/rn73 #16807
Feat/rn73 #16807
Conversation
8369d3a
to
537df99
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16807 +/- ##
==========================================
+ Coverage 58.50% 58.52% +0.01%
==========================================
Files 466 466
Lines 27107 27099 -8
Branches 5927 5914 -13
==========================================
Hits 15860 15860
+ Misses 9902 9770 -132
- Partials 1345 1469 +124
Flags with carried forward coverage won't be shown. Click here to find out more.
|
能否把#16747的修改也放到这个PR一下? |
可以,感谢 |
2e85afa
to
7d62cac
Compare
@SidneyLann 试一下 4.0.7-canary.4 |
还没review就已发布了吗? |
canary 包,测试用 |
试了。linaria没问题。但是这句有undefined的异常, main分支已改了,为什么没同步到4.x? |
/node_modules/expo-modules-core/android/src/main/java/expo/modules/adapters/react/permissions/PermissionsService.kt:166:16 |
https://github.com/NervJS/taro/blob/feat/rn73/packages/taro-runtime-rn/src/app.tsx 代码是一样的 |
expo sdk 50 确实有这个问题,需要自行 patch |
* upgrade linaria to latest version * use className instead style * format * restore * use space instead of tab * tweak for submit fail * t --------- Co-authored-by: Administrator <Administrator@tech8>
7d62cac
to
7519a93
Compare
那这句从哪来?这句我要改成如下才能跑,不然报undefined的异常: |
我跑完yarn upgradePeerdeps后,仅修改react-native,@react-native/gradle-plugin的版本为0.75.4,项目就能跑通,为什么不直接升级到0.75.4或者0.76.0? |
等 0.76 稳定后会升。0.73 是之前 4.x 的兼容版本,目前是修复问题。 |
* feat: native libs version check * feat: rimraf * fix: build & test error * fix: stylelint version * upgrade linaria to latest version (#16747) * upgrade linaria to latest version * use className instead style * format * restore * use space instead of tab * tweak for submit fail * t --------- Co-authored-by: Administrator <Administrator@tech8> * fix(rn): undefinde error --------- Co-authored-by: f <voiddlanson@163.com> Co-authored-by: Administrator <Administrator@tech8>
这个 PR 做了什么? (简要描述所做更改)
rimraf --impl=move-remove
改成rimraf
。因为项目在mac 移动硬盘中无法编译。--impl=move-remove 是否有必要保留?正常情况在用默认的就行,不必要特别指定。babel-plugin-minify-dead-code-elimination
对应的资源
测试版本:4.0.7-canary.4
这个 PR 是什么类型? (至少选择一个)
这个 PR 涉及以下平台: